-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modify referral fees #284
Conversation
1fc7d7a
to
15d2227
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good and the switching of internal/external look right but the use of affiliate vs referral is sort of confusing so can you just state out the desired target for the changes and when it's affiliate vs referral?
|
||
// Setup default state | ||
questFactoryContract = IQuestFactory(payable(msg.sender)); | ||
queued = true; | ||
referralClaimTotal = 0; | ||
totalReferralsFeesClaimed = 0; | ||
referralRewardFee = 250; // 2.5% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why hardcode vs pass it in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to hardcode it, but we could pass it in (and move hardcode to the QuestFactory instead)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - confirmed the withdrawal logic too just to be safe. Everything checks out.
0f44183
to
6cb07c2
Compare
6cb07c2
to
9f10ed7
Compare
No description provided.